plugin updates

wp/wp-content/plugins/wordpress-seo/admin/class-yoast-form.php

@@ -721,6 +721,8 @@ class Yoast_Form {
 	 * Media input.
 	 *
 	 * @since 2.0
+	 * @deprecated 23.5
+	 * @codeCoverageIgnore
 	 *
 	 * @param string $variable Option name.
 	 * @param string $label    Label message.
@@ -729,6 +731,9 @@ class Yoast_Form {
 	 * @return void
 	 */
 	public function media_input( $variable, $label, $attr = [] ) {
+
+		_deprecated_function( __METHOD__, 'Yoast SEO 23.5' );
+
 		$val      = $this->get_field_value( $variable, '' );
 		$id_value = $this->get_field_value( $variable . '_id', '' );
 
@@ -749,8 +754,6 @@ class Yoast_Form {
 
 		$id_field_id = 'wpseo_' . $var_esc . '_id';
 
-		$disabled_attribute = $this->get_disabled_attribute( $variable, $attr );
-
 		echo '<span>';
 			echo '<input',
 				' class="textinput"',
@@ -760,22 +763,6 @@ class Yoast_Form {
 				' value="', esc_attr( $val ), '"',
 				' readonly="readonly"',
 				' /> ';
-			echo '<input',
-				' id="wpseo_', $var_esc, '_button"', // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- output escaped before.
-				' class="wpseo_image_upload_button button"',
-				' type="button"',
-				' value="', esc_attr__( 'Upload Image', 'wordpress-seo' ), '"',
-				' data-target-id="', esc_attr( $id_field_id ), '"',
-				// phpcs:ignore WordPress.Security.EscapeOutput -- Reason: $disabled_attribute output is hardcoded.
-				$disabled_attribute,
-				' /> ';
-			echo '<input',
-				' class="wpseo_image_remove_button button"',
-				' type="button"',
-				' value="', esc_attr__( 'Clear Image', 'wordpress-seo' ), '"',
-				// phpcs:ignore WordPress.Security.EscapeOutput -- Reason: $disabled_attribute output is hardcoded.
-				$disabled_attribute,
-				' />';
 			echo '<input',
 				' type="hidden"',
 				' id="', esc_attr( $id_field_id ), '"',